initial commit 2

1 files changed, 285 insertions, 0 deletions

diff --git a/addons/sale_timesheet/tests/test_reinvoice.py b/addons/sale_timesheet/tests/test_reinvoice.py
new file mode 100644
index 00000000..0b85f450
--- /dev/null
+++ b/addons/sale_timesheet/tests/test_reinvoice.py
@@ -0,0 +1,285 @@
+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+from odoo.addons.sale_timesheet.tests.common import TestCommonSaleTimesheet
+from odoo.tests import Form, tagged
+
+
+@tagged('-at_install', 'post_install')
+class TestReInvoice(TestCommonSaleTimesheet):
+
+    @classmethod
+    def setUpClass(cls, chart_template_ref=None):
+        super().setUpClass(chart_template_ref=chart_template_ref)
+
+        # patch expense products to make them services creating task/project
+        service_values = {
+            'type': 'service',
+            'service_type': 'timesheet',
+            'service_tracking': 'task_in_project'
+        }
+        cls.company_data['product_order_cost'].write(service_values)
+        cls.company_data['product_delivery_cost'].write(service_values)
+        cls.company_data['product_order_sales_price'].write(service_values)
+        cls.company_data['product_delivery_sales_price'].write(service_values)
+        cls.company_data['product_order_no'].write(service_values)
+
+        # create AA, SO and invoices
+        cls.analytic_account = cls.env['account.analytic.account'].create({
+            'name': 'Test AA',
+            'code': 'TESTSALE_TIMESHEET_REINVOICE',
+            'company_id': cls.company_data['company'].id,
+            'partner_id': cls.partner_a.id
+        })
+
+        cls.sale_order = cls.env['sale.order'].with_context(mail_notrack=True, mail_create_nolog=True).create({
+            'partner_id': cls.partner_a.id,
+            'partner_invoice_id': cls.partner_a.id,
+            'partner_shipping_id': cls.partner_a.id,
+            'analytic_account_id': cls.analytic_account.id,
+            'pricelist_id': cls.company_data['default_pricelist'].id,
+        })
+
+        cls.Invoice = cls.env['account.move'].with_context(
+            default_move_type='in_invoice',
+            default_invoice_date=cls.sale_order.date_order,
+            mail_notrack=True,
+            mail_create_nolog=True,
+        )
+
+    def test_at_cost(self):
+        """ Test vendor bill at cost for product based on ordered and delivered quantities. """
+        # create SO line and confirm SO (with only one line)
+        sale_order_line1 = self.env['sale.order.line'].create({
+            'name': self.company_data['product_order_cost'].name,
+            'product_id': self.company_data['product_order_cost'].id,
+            'product_uom_qty': 2,
+            'product_uom': self.company_data['product_order_cost'].uom_id.id,
+            'price_unit': self.company_data['product_order_cost'].list_price,
+            'order_id': self.sale_order.id,
+        })
+        sale_order_line1.product_id_change()
+        sale_order_line2 = self.env['sale.order.line'].create({
+            'name': self.company_data['product_delivery_cost'].name,
+            'product_id': self.company_data['product_delivery_cost'].id,
+            'product_uom_qty': 4,
+            'product_uom': self.company_data['product_delivery_cost'].uom_id.id,
+            'price_unit': self.company_data['product_delivery_cost'].list_price,
+            'order_id': self.sale_order.id,
+        })
+        sale_order_line2.product_id_change()
+
+        self.sale_order.onchange_partner_id()
+        self.sale_order._compute_tax_id()
+        self.sale_order.action_confirm()
+
+        self.assertEqual(sale_order_line1.qty_delivered_method, 'timesheet', "Delivered quantity of 'service' SO line should be computed by timesheet amount")
+        self.assertEqual(sale_order_line2.qty_delivered_method, 'timesheet', "Delivered quantity of 'service' SO line should be computed by timesheet amount")
+
+        # let's log some timesheets (on the project created by sale_order_line1)
+        task_sol1 = sale_order_line1.task_id
+        self.env['account.analytic.line'].create({
+            'name': 'Test Line',
+            'project_id': task_sol1.project_id.id,
+            'task_id': task_sol1.id,
+            'unit_amount': 1,
+            'employee_id': self.employee_user.id,
+            'company_id': self.company_data['company'].id,
+        })
+
+        move_form = Form(self.Invoice)
+        move_form.partner_id = self.partner_a
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_order_cost']
+            line_form.quantity = 3.0
+            line_form.analytic_account_id = self.analytic_account
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_delivery_cost']
+            line_form.quantity = 3.0
+            line_form.analytic_account_id = self.analytic_account
+        invoice_a = move_form.save()
+        invoice_a.action_post()
+
+        sale_order_line3 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line1 and sol.product_id == self.company_data['product_order_cost'])
+        sale_order_line4 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line2 and sol.product_id == self.company_data['product_delivery_cost'])
+
+        self.assertTrue(sale_order_line3, "A new sale line should have been created with ordered product")
+        self.assertTrue(sale_order_line4, "A new sale line should have been created with delivered product")
+        self.assertEqual(len(self.sale_order.order_line), 4, "There should be 4 lines on the SO (2 vendor bill lines created)")
+        self.assertEqual(len(self.sale_order.order_line.filtered(lambda sol: sol.is_expense)), 2, "There should be 4 lines on the SO (2 vendor bill lines created)")
+
+        self.assertEqual(sale_order_line1.qty_delivered, 1, "Exising SO line 1 should not be impacted by reinvoicing product at cost")
+        self.assertEqual(sale_order_line2.qty_delivered, 0, "Exising SO line 2 should not be impacted by reinvoicing product at cost")
+
+        self.assertFalse(sale_order_line3.task_id, "Adding a new expense SO line should not create a task (sol3)")
+        self.assertFalse(sale_order_line4.task_id, "Adding a new expense SO line should not create a task (sol4)")
+        self.assertEqual(len(self.sale_order.project_ids), 1, "SO create only one project with its service line. Adding new expense SO line should not impact that")
+
+        self.assertEqual((sale_order_line3.price_unit, sale_order_line3.qty_delivered, sale_order_line3.product_uom_qty, sale_order_line3.qty_invoiced), (self.company_data['product_order_cost'].standard_price, 3.0, 0, 0), 'Sale line is wrong after confirming vendor invoice')
+        self.assertEqual((sale_order_line4.price_unit, sale_order_line4.qty_delivered, sale_order_line4.product_uom_qty, sale_order_line4.qty_invoiced), (self.company_data['product_delivery_cost'].standard_price, 3.0, 0, 0), 'Sale line is wrong after confirming vendor invoice')
+
+        self.assertEqual(sale_order_line3.qty_delivered_method, 'analytic', "Delivered quantity of 'expense' SO line should be computed by analytic amount")
+        self.assertEqual(sale_order_line4.qty_delivered_method, 'analytic', "Delivered quantity of 'expense' SO line should be computed by analytic amount")
+
+        # create second invoice lines and validate it
+        move_form = Form(self.Invoice)
+        move_form.partner_id = self.partner_a
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_order_cost']
+            line_form.quantity = 2.0
+            line_form.analytic_account_id = self.analytic_account
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_delivery_cost']
+            line_form.quantity = 2.0
+            line_form.analytic_account_id = self.analytic_account
+        invoice_b = move_form.save()
+        invoice_b.action_post()
+
+        sale_order_line5 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line1 and sol != sale_order_line3 and sol.product_id == self.company_data['product_order_cost'])
+        sale_order_line6 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line2 and sol != sale_order_line4 and sol.product_id == self.company_data['product_delivery_cost'])
+
+        self.assertTrue(sale_order_line5, "A new sale line should have been created with ordered product")
+        self.assertTrue(sale_order_line6, "A new sale line should have been created with delivered product")
+
+        self.assertEqual(len(self.sale_order.order_line), 6, "There should be still 4 lines on the SO, no new created")
+        self.assertEqual(len(self.sale_order.order_line.filtered(lambda sol: sol.is_expense)), 4, "There should be still 2 expenses lines on the SO")
+
+        self.assertEqual((sale_order_line5.price_unit, sale_order_line5.qty_delivered, sale_order_line5.product_uom_qty, sale_order_line5.qty_invoiced), (self.company_data['product_order_cost'].standard_price, 2.0, 0, 0), 'Sale line 5 is wrong after confirming 2e vendor invoice')
+        self.assertEqual((sale_order_line6.price_unit, sale_order_line6.qty_delivered, sale_order_line6.product_uom_qty, sale_order_line6.qty_invoiced), (self.company_data['product_delivery_cost'].standard_price, 2.0, 0, 0), 'Sale line 6 is wrong after confirming 2e vendor invoice')
+
+    def test_sales_price(self):
+        """ Test invoicing vendor bill at sales price for products based on delivered and ordered quantities. Check no existing SO line is incremented, but when invoicing a
+            second time, increment only the delivered so line.
+        """
+        # create SO line and confirm SO (with only one line)
+        sale_order_line1 = self.env['sale.order.line'].create({
+            'name': self.company_data['product_delivery_sales_price'].name,
+            'product_id': self.company_data['product_delivery_sales_price'].id,
+            'product_uom_qty': 2,
+            'qty_delivered': 1,
+            'product_uom': self.company_data['product_delivery_sales_price'].uom_id.id,
+            'price_unit': self.company_data['product_delivery_sales_price'].list_price,
+            'order_id': self.sale_order.id,
+        })
+        sale_order_line1.product_id_change()
+        sale_order_line2 = self.env['sale.order.line'].create({
+            'name': self.company_data['product_order_sales_price'].name,
+            'product_id': self.company_data['product_order_sales_price'].id,
+            'product_uom_qty': 3,
+            'qty_delivered': 1,
+            'product_uom': self.company_data['product_order_sales_price'].uom_id.id,
+            'price_unit': self.company_data['product_order_sales_price'].list_price,
+            'order_id': self.sale_order.id,
+        })
+        sale_order_line2.product_id_change()
+        self.sale_order._compute_tax_id()
+        self.sale_order.action_confirm()
+
+        # let's log some timesheets (on the project created by sale_order_line1)
+        task_sol1 = sale_order_line1.task_id
+        self.env['account.analytic.line'].create({
+            'name': 'Test Line',
+            'project_id': task_sol1.project_id.id,
+            'task_id': task_sol1.id,
+            'unit_amount': 1,
+            'employee_id': self.employee_user.id,
+        })
+
+        # create invoice lines and validate it
+        move_form = Form(self.Invoice)
+        move_form.partner_id = self.partner_a
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_delivery_sales_price']
+            line_form.quantity = 3.0
+            line_form.analytic_account_id = self.analytic_account
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_order_sales_price']
+            line_form.quantity = 3.0
+            line_form.analytic_account_id = self.analytic_account
+        invoice_a = move_form.save()
+        invoice_a.action_post()
+
+        sale_order_line3 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line1 and sol.product_id == self.company_data['product_delivery_sales_price'])
+        sale_order_line4 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line2 and sol.product_id == self.company_data['product_order_sales_price'])
+
+        self.assertTrue(sale_order_line3, "A new sale line should have been created with ordered product")
+        self.assertTrue(sale_order_line4, "A new sale line should have been created with delivered product")
+        self.assertEqual(len(self.sale_order.order_line), 4, "There should be 4 lines on the SO (2 vendor bill lines created)")
+        self.assertEqual(len(self.sale_order.order_line.filtered(lambda sol: sol.is_expense)), 2, "There should be 4 lines on the SO (2 vendor bill lines created)")
+
+        self.assertEqual(sale_order_line1.qty_delivered, 1, "Exising SO line 1 should not be impacted by reinvoicing product at cost")
+        self.assertEqual(sale_order_line2.qty_delivered, 0, "Exising SO line 2 should not be impacted by reinvoicing product at cost")
+
+        self.assertFalse(sale_order_line3.task_id, "Adding a new expense SO line should not create a task (sol3)")
+        self.assertFalse(sale_order_line4.task_id, "Adding a new expense SO line should not create a task (sol4)")
+        self.assertEqual(len(self.sale_order.project_ids), 1, "SO create only one project with its service line. Adding new expense SO line should not impact that")
+
+        self.assertEqual((sale_order_line3.price_unit, sale_order_line3.qty_delivered, sale_order_line3.product_uom_qty, sale_order_line3.qty_invoiced), (self.company_data['product_delivery_sales_price'].list_price, 3.0, 0, 0), 'Sale line is wrong after confirming vendor invoice')
+        self.assertEqual((sale_order_line4.price_unit, sale_order_line4.qty_delivered, sale_order_line4.product_uom_qty, sale_order_line4.qty_invoiced), (self.company_data['product_order_sales_price'].list_price, 3.0, 0, 0), 'Sale line is wrong after confirming vendor invoice')
+
+        self.assertEqual(sale_order_line3.qty_delivered_method, 'analytic', "Delivered quantity of 'expense' SO line 3 should be computed by analytic amount")
+        self.assertEqual(sale_order_line4.qty_delivered_method, 'analytic', "Delivered quantity of 'expense' SO line 4 should be computed by analytic amount")
+
+        # create second invoice lines and validate it
+        move_form = Form(self.Invoice)
+        move_form.partner_id = self.partner_a
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_delivery_sales_price']
+            line_form.quantity = 2.0
+            line_form.analytic_account_id = self.analytic_account
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_order_sales_price']
+            line_form.quantity = 2.0
+            line_form.analytic_account_id = self.analytic_account
+        invoice_b = move_form.save()
+        invoice_b.action_post()
+
+        sale_order_line5 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line1 and sol != sale_order_line3 and sol.product_id == self.company_data['product_delivery_sales_price'])
+        sale_order_line6 = self.sale_order.order_line.filtered(lambda sol: sol != sale_order_line2 and sol != sale_order_line4 and sol.product_id == self.company_data['product_order_sales_price'])
+
+        self.assertFalse(sale_order_line5, "No new sale line should have been created with delivered product !!")
+        self.assertTrue(sale_order_line6, "A new sale line should have been created with ordered product")
+
+        self.assertEqual(len(self.sale_order.order_line), 5, "There should be 5 lines on the SO, 1 new created and 1 incremented")
+        self.assertEqual(len(self.sale_order.order_line.filtered(lambda sol: sol.is_expense)), 3, "There should be 3 expenses lines on the SO")
+
+        self.assertEqual((sale_order_line6.price_unit, sale_order_line6.qty_delivered, sale_order_line4.product_uom_qty, sale_order_line6.qty_invoiced), (self.company_data['product_order_sales_price'].list_price, 2.0, 0, 0), 'Sale line is wrong after confirming 2e vendor invoice')
+
+    def test_no_expense(self):
+        """ Test invoicing vendor bill with no policy. Check nothing happen. """
+        # confirm SO
+        sale_order_line = self.env['sale.order.line'].create({
+            'name': self.company_data['product_order_no'].name,
+            'product_id': self.company_data['product_order_no'].id,
+            'product_uom_qty': 2,
+            'qty_delivered': 1,
+            'product_uom': self.company_data['product_order_no'].uom_id.id,
+            'price_unit': self.company_data['product_order_no'].list_price,
+            'order_id': self.sale_order.id,
+        })
+        self.sale_order._compute_tax_id()
+        self.sale_order.action_confirm()
+
+        # create invoice lines and validate it
+        move_form = Form(self.Invoice)
+        move_form.partner_id = self.partner_a
+        with move_form.line_ids.new() as line_form:
+            line_form.product_id = self.company_data['product_order_no']
+            line_form.quantity = 3.0
+            line_form.analytic_account_id = self.analytic_account
+        invoice_a = move_form.save()
+        invoice_a.action_post()
+
+        # let's log some timesheets (on the project created by sale_order_line1)
+        task_sol1 = sale_order_line.task_id
+        self.env['account.analytic.line'].create({
+            'name': 'Test Line',
+            'project_id': task_sol1.project_id.id,
+            'task_id': task_sol1.id,
+            'unit_amount': 1,
+            'employee_id': self.employee_user.id,
+        })
+
+        self.assertEqual(len(self.sale_order.order_line), 1, "No SO line should have been created (or removed) when validating vendor bill")
+        self.assertEqual(sale_order_line.qty_delivered, 1, "The delivered quantity of SO line should not have been incremented")
+        self.assertTrue(invoice_a.mapped('line_ids.analytic_line_ids'), "Analytic lines should be generated")