refactor tracking history due extension on invoice

1 files changed, 7 insertions, 13 deletions

diff --git a/indoteknik_custom/models/account_move_due_extension.py b/indoteknik_custom/models/account_move_due_extension.py
index 18bb7599..43207534 100644
--- a/indoteknik_custom/models/account_move_due_extension.py
+++ b/indoteknik_custom/models/account_move_due_extension.py
@@ -139,7 +139,10 @@ class DueExtensionLine(models.Model):
 
     due_id = fields.Many2one('due.extension', string='Due Ref', required=True, ondelete='cascade', index=True, copy=False)
     due_description = fields.Text(string="Description", compute="_compute_due_description")
-    due_approval_status = fields.Char(string="Approval Status", compute="_compute_due_approval_status")
+    due_approval_status = fields.Selection([
+        ('pengajuan', 'Pengajuan'),
+        ('approved', 'Approved'),
+    ], string="Approval Status", compute="_compute_due_approval_status")
     due_day_extension = fields.Char(string="Day Extension", compute="_compute_due_day_extension")
     partner_id = fields.Many2one('res.partner', string='Customer')
     invoice_id = fields.Many2one('account.move', string='Invoice')
@@ -153,24 +156,15 @@ class DueExtensionLine(models.Model):
 
     def _compute_due_description(self):
         for line in self:
-            if line.due_id.description:
-                line.due_description = line.due_id.description
-            else:
-                line.due_description = '-'
+            line.due_description = line.due_id.description
 
     def _compute_due_approval_status(self):
         for line in self:
-            if line.due_id.approval_status:
-                line.due_approval_status = line.due_id.approval_status
-            else:
-                line.due_approval_status = '-'
+            line.due_approval_status = line.due_id.approval_status
 
     def _compute_due_day_extension(self):
         for line in self:
-            if line.due_id.day_extension:
-                line.due_day_extension = line.due_id.day_extension
-            else:
-                line.due_day_extension = '-'
+            line.due_day_extension = line.due_id.day_extension
 
     def _compute_day_to_due(self):
         for line in self: